Push saved config to the server without waiting for the sync timer#54
Merged
Conversation
A saved feed.env change (e.g. enabling remote configuration) now reaches the server within seconds instead of waiting for the ~60s config-sync timer tick. After an applied write webconfig starts airplanes-config-sync.service --no-block; the unit self-gates.
d4rken
force-pushed
the
feat/nudge-config-sync-on-save
branch
from
3f40e55 to
e8bf10d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Saving a setting in the on-device webconfig — for example enabling remote configuration — now propagates to airplanes.live within seconds. Previously the change sat on the feeder until the next config-sync timer tick (up to ~90s).
After a successful save, webconfig starts the config-sync service directly instead of letting it wait for its periodic tick. The service still self-gates on the claim secret and the remote-config opt-in, so an unclaimed or opted-out feeder is unaffected.